Messages in this thread | | | From | "Levy, Amir (Jer)" <> | Subject | RE: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware) | Date | Sun, 31 Jul 2016 10:18:29 +0000 |
| |
On Sat, Jul 30 2016, 12:48 AM, Greg KH wrote: > On Fri, Jul 29, 2016 at 02:02:24PM -0700, Stephen Hemminger wrote: > > On Thu, 28 Jul 2016 11:15:17 +0300 > > Amir Levy <amir.jer.levy@intel.com> wrote: > > > > > +static LIST_HEAD(controllers_list); static > > > +DECLARE_RWSEM(controllers_list_rwsem); > > > > Why use a semaphore when simple spinlock or mutex would be better? > > And never use a RW semaphore unless you can benchmark the difference > from a normal lock. If you can't benchmark it, then don't use it...
I used RW semaphore since most of the time the list will be accessed for read. Since it is used in non-time sensitive flows, I'll change it to mutex.
| |