Messages in this thread | | | Date | Fri, 29 Jul 2016 10:46:43 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH] s390/pci: Remove unnecessary if condition |
| |
On Fri, 29 Jul 2016, Sebastian Ott wrote:
> On Fri, 29 Jul 2016, Amitoj Kaur Chawla wrote: > > Remove unnecessary error handling because the only failure value that > > can be returned is NULL and so the test can never be true. > > > > The Coccinelle semantic patch used to make this change is as follows: > > @@ > > expression e; > > @@ > > > > e = debugfs_create_file(...); > > - if(IS_ERR(e)) { e = NULL; } > > Nope. For !CONFIG_DEBUG_FS debugfs_create_file returns an ERR_PTR.
Clicking around in lxr doesn't show that, but perhaps an alternative definition is overlooked?
julia
| |