Messages in this thread | | | From | Allen Hubbe <> | Date | Fri, 29 Jul 2016 21:41:12 -0400 | Subject | Re: [PATCH] checkpatch: fix perl warning about unescaped brace |
| |
On Fri, Jul 29, 2016 at 7:57 PM, Allen Hubbe <allenbh@gmail.com> wrote: > On Fri, Jul 29, 2016 at 7:06 PM, Joe Perches <joe@perches.com> wrote: >> On Fri, 2016-07-29 at 18:27 -0400, Allen Hubbe wrote: >>> Perl warns: >>> >>> Unescaped left brace in regex is deprecated, passed through in regex >>> >>> This is explained under "Quantifiers" in perl doc: >>> http://perldoc.perl.org/perlre.html#Quantifiers >> >> Hey Allen. >> >> I'm at 5.22 and don't see a warning. >> For what version of perl does this warning get generated? >> Only 5.24 and higher? > > This system has v5.22.1. I don't know exactly how this perl was > configured. I didn't see the warning on other systems. Strangely, I > don't remember seeing it yesterday on this system, either. I might > try to reproduce the warning on another system and let you know. The > warning and this fix seem to be in line with the perl documentation, > though. > > perl --version > > This is perl 5, version 22, subversion 1 (v5.22.1) built for > x86_64-linux-thread-multi > (with 15 registered patches, see perl -V for more detail) > > cat /etc/fedora-release > Fedora release 23 (Twenty Three)
Mystery solved... and drop this patch.
My 'master' on this system was set to an old ref, v4.2-rc1. There are no perl warnings as of v4.7.
docker pull fedora docker run -it --rm fedora /bin/bash dnf install wget perl perl-Term-ANSIColor perl-Getopt-Long
wget https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl perl -c checkpatch.pl
huh... no errors :-/
wget https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl?h=v4.2-rc1 perl -c checkpatch.pl\?h\=v4.2-rc1
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/\#\s*define.*do\s{ <-- HERE / at checkpatch.pl?h=v4.2-rc1 line 3523. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/\(.*\){ <-- HERE / at checkpatch.pl?h=v4.2-rc1 line 4035. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/do{ <-- HERE / at checkpatch.pl?h=v4.2-rc1 line 4036. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/^\({ <-- HERE / at checkpatch.pl?h=v4.2-rc1 line 4483.
| |