lkml.org 
[lkml]   [2016]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation
Date
> -----Original Message-----
> From: Sean Paul [mailto:seanpaul@google.com]
> Sent: Friday, July 29, 2016 3:35 PM
> To: Wei Yongjun
> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang, Sonny; Liu, Leo;
> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk; dri-devel;
> Linux Kernel Mailing List
> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than
> duplicating its implementation
>
> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> > Use kmemdup rather than duplicating its implementation.
> >
> > Generated by: scripts/coccinelle/api/memdup.cocci
> >
> > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>
>
> Thanks for the patch. I'll apply this to -misc once the merge window is closed.
>
> Acked-by: Sean Paul <seanpaul@chromium.org>

Unless you've already applied this to the misc tree, I'd prefer to take it via the amdgpu tree.

Alex

>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > index a46a64c..b779b5f 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> > @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device
> *adev)
> > size = amdgpu_bo_size(adev->uvd.vcpu_bo);
> > ptr = adev->uvd.cpu_addr;
> >
> > - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL);
> > + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL);
> > if (!adev->uvd.saved_bo)
> > return -ENOMEM;
> >
> > - memcpy(adev->uvd.saved_bo, ptr, size);
> > -
> > return 0;
> > }
> >
> >
> >
> >
\
 
 \ /
  Last update: 2016-07-30 00:41    [W:0.098 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site