lkml.org 
[lkml]   [2016]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer
From
Date
On Fri, 2016-07-29 at 13:10 +0200, Nicolas Iooss wrote:
> handle_object_size_mismatch() used %pk to format a kernel pointer in
> pr_err().  This seems to be a misspelling for %pK.

Thanks


> diff --git a/lib/ubsan.c b/lib/ubsan.c
[]
> @@ -308,7 +308,7 @@ static void handle_object_size_mismatch(struct
> type_mismatch_data *data,
>   return;
>  
>   ubsan_prologue(&data->location, &flags);
> - pr_err("%s address %pk with insufficient space\n",
> + pr_err("%s address %pK with insufficient space\n",
>   type_check_kinds[data->type_check_kind],
>   (void *) ptr);
>   pr_err("for an object of type %s\n", data->type->type_name);

Maybe change this to a single output line:

pr_err("%s address %pK with insufficient space for an object of type %s\n",
type_check_kinds[data->type_check_kind], (void *)ptr,
data->type->type_name);

\
 
 \ /
  Last update: 2016-07-29 22:21    [W:0.104 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site