lkml.org 
[lkml]   [2016]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch: check signoff when reading stdin
From
Date
On Fri, 2016-07-29 at 10:45 -0400, Allen Hubbe wrote:
> On Wed, Jul 27, 2016 at 8:41 PM, Joe Perches <joe@perches.com> wrote:
> >
> > I think this is not a great idea because the most likely
> > use case is piping git diff output ala:
> >
> > $ git diff <some_path> | ./scripts/checkpatch.pl -
> Thanks for the review.  Has v2 addressed your concern?

Hi Allen.

For the most part, yes, your V2 works better.

I was wondering if the - should be optional and thinking
$ git diff <some-path> | ./scripts/checkpatch.pl
should work the same way, but I guess that can wait for
another day, so

Acked-by: Joe Perches <joe@perches.com>

cheers, Joe

\
 
 \ /
  Last update: 2016-07-29 18:21    [W:0.128 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site