lkml.org 
[lkml]   [2016]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 4/7] arm64: Use simpler API for random address requests
On Thu, Jul 28, 2016 at 08:47:27PM +0000, Jason Cooper wrote:
> Currently, all callers to randomize_range() set the length to 0 and
> calculate end by adding a constant to the start address. We can
> simplify the API to remove a bunch of needless checks and variables.
>
> Use the new randomize_addr(start, range) call to set the requested
> address.
>
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> ---
> arch/arm64/kernel/process.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
> index 6cd2612236dc..11bf454baf86 100644
> --- a/arch/arm64/kernel/process.c
> +++ b/arch/arm64/kernel/process.c
> @@ -374,12 +374,8 @@ unsigned long arch_align_stack(unsigned long sp)
>
> unsigned long arch_randomize_brk(struct mm_struct *mm)
> {
> - unsigned long range_end = mm->brk;
> -
> if (is_compat_task())
> - range_end += 0x02000000;
> + return randomize_addr(mm->brk, 0x02000000);
> else
> - range_end += 0x40000000;
> -
> - return randomize_range(mm->brk, range_end, 0) ? : mm->brk;
> + return randomize_addr(mm->brk, 0x40000000);

Looks fine to me, once the core code has settled down:

Acked-by: Will Deacon <will.deacon@arm.com>

Will

\
 
 \ /
  Last update: 2016-07-29 16:21    [W:0.210 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site