lkml.org 
[lkml]   [2016]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] x86/platform/UV: Fix problem with bad UV4 EFI System Table causing panic
On Wed, 27 Jul 2016, Mike Travis wrote:

> Fix a problem that occurs if for some reason the UV4 EFI System Table
> is not available, the check inadvertantly can cause a panic.
>
> Reviewed-by: Dimitri Sivanich <sivanich@sgi.com>
> Reviewed-by: Nathan Zimmer <nzimmer@sgi.com>
> Tested-by: Frank Ramsay <framsay@sgi.com>
> Tested-by: John Estabrook <estabrook@sgi.com>
> Signed-off-by: Mike Travis <travis@sgi.com>
> ---
> arch/x86/platform/uv/bios_uv.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> --- linux-3.12.orig/arch/x86/platform/uv/bios_uv.c
> +++ linux-3.12/arch/x86/platform/uv/bios_uv.c
> @@ -201,11 +201,12 @@ void uv_bios_init(void)
> }
>
> if (uv_systab->revision >= UV_SYSTAB_VERSION_UV4) {
> + int size = uv_systab->size;
> +
> iounmap(uv_systab);
> - uv_systab = ioremap(efi.uv_systab, uv_systab->size);

I think the changelog is bogus. What's happening here is a classic use after
unmap, which you avoid by this change.

> + uv_systab = ioremap(efi.uv_systab, size);

Hmm?

tglx

\
 
 \ /
  Last update: 2016-07-29 14:01    [W:0.103 / U:2.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site