Messages in this thread | | | Date | Fri, 29 Jul 2016 11:35:14 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH 3/5] i2c: i801: use BIT() macro for bits definition |
| |
On Thu, 28 Jul 2016 11:50:41 +0200, Benjamin Tissoires wrote: > i801 mixes hexadecimal and decimal values for defining bits. However, > we have a nice BIT() macro for this exact purpose.
Looks good to me. But maybe we could convert all the FEATURE_* defines as well?
> No functional changes, cleanup only. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > drivers/i2c/busses/i2c-i801.c | 50 +++++++++++++++++++++---------------------- > 1 file changed, 25 insertions(+), 25 deletions(-) > (...)
Reviewed-by: Jean Delvare <jdelvare@suse.de>
-- Jean Delvare SUSE L3 Support
| |