lkml.org 
[lkml]   [2016]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion
On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote:

> On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote:
> > From: Daniel Wagner <daniel.wagner@bmw-carit.de>
> >
[..]
>
> Do not quite like it... I'd rather asynchronous request give out a
> firmware status pointer that could be used later on.
>
> pcu->fw_st = request_firmware_async(IMS_PCU_FIRMWARE_NAME,
> pcu,
> ims_pcu_process_async_firmware);
> if (IS_ERR(pcu->fw_st))
> return PTR_ERR(pcu->fw_st);
>
> ....
>
> fw_loading_wait(pcu->fw_st);
>

In the remoteproc case (patch 6) this would clean up the code, rather
than replacing the completion API 1 to 1. I like it!

Regards,
Bjorn

\
 
 \ /
  Last update: 2016-07-28 21:41    [W:0.184 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site