Messages in this thread | | | Subject | Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments | From | Oliver Neukum <> | Date | Wed, 27 Jul 2016 21:10:49 +0200 |
| |
On Wed, 2016-07-27 at 18:08 +0200, Mathieu OTHACEHE wrote: > Hi, > > > this makes me think something is wrong with the data structure. > > We should have a be32 there, it seems to me. > > You mean something like : > > struct ti_write_data_bytes { > u8 bAddrType; > u8 bDataType; > u8 bDataCounter; > __be32 wBaseAddr; > u8 bData[0]; > } __packed; > > and, > > data->wBaseAddr = cpu_to_be32(addr) ?
Yes.
Regards Oliver
| |