lkml.org 
[lkml]   [2016]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments
From
Date
On Wed, 2016-07-27 at 18:08 +0200, Mathieu OTHACEHE wrote:
> Hi,
>
> > this makes me think something is wrong with the data structure.
> > We should have a be32 there, it seems to me.
>
> You mean something like :
>
> struct ti_write_data_bytes {
> u8 bAddrType;
> u8 bDataType;
> u8 bDataCounter;
> __be32 wBaseAddr;
> u8 bData[0];
> } __packed;
>
> and,
>
> data->wBaseAddr = cpu_to_be32(addr) ?

Yes.

Regards
Oliver


\
 
 \ /
  Last update: 2016-07-27 22:01    [W:1.572 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site