Messages in this thread | | | From | <> | Subject | Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s | Date | Wed, 27 Jul 2016 15:55:09 +0000 |
| |
> Hi! I'm not sure if KEY_PROG1/2/3 are good names here as we already use >those for other actions (see bios_to_linux_keycode). Also there is:
I had missed this, do you have some recommendations on what would be better codes to map this to?
I'll double check what the things that "were" mapping to KEY_PROG1 etc actually were. This might be a case of an expected clash if the functions aren't in current generations.
> >/* Wifi Catcher */ > { KE_KEY, 0xe011, { KEY_PROG2 } }, >
It's worth mentioning that Wifi Catcher hasn't been used for any Dell laptops for a handful generations. The rugged 2in1's are current generation that have these programmable buttons and don't have wifi catcher.
So there should be no "real" clash here.
> But probably we do not have better names...
In this particular case, I was thinking PROG1/2/3 were really the best option and would be most intuitive because the keys really are labels "P1" "P2" and "P3".
Here's the front of the tablet: http://shop-media.intel.com/api/v2/helperservice/getimage?url=http://images.icecat.biz/img/norm/high/30031725-706.jpg&height=550&width=550
> > Another small cosmetic change: align WMI codes, so 0x157 and 0x850 are > at some column (similar like are formatted other actions).
OK.
| |