lkml.org 
[lkml]   [2016]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] apparmor: fix SECURITY_APPARMOR_HASH_DEFAULT parameter handling
    On Mon, 25 Jul 2016, John Johansen wrote:

    > From: Arnd Bergmann <arnd@arndb.de>
    >
    > The newly added Kconfig option could never work and just causes a build error
    > when disabled:
    >
    > security/apparmor/lsm.c:675:25: error: 'CONFIG_SECURITY_APPARMOR_HASH_DEFAULT' undeclared here (not in a function)
    > bool aa_g_hash_policy = CONFIG_SECURITY_APPARMOR_HASH_DEFAULT;
    >
    > The problem is that the macro undefined in this case, and we need to use the IS_ENABLED()
    > helper to turn it into a boolean constant.
    >
    > Another minor problem with the original patch is that the option is even offered
    > in sysfs when SECURITY_APPARMOR_HASH is not enabled, so this also hides the option
    > in that case.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > Fixes: 6059f71f1e94 ("apparmor: add parameter to control whether policy hashing is used")
    > Signed-off-by: John Johansen <john.johansen@canonical.com>

    Please rebase this against current Linus.

    --
    James Morris
    <jmorris@namei.org>

    \
     
     \ /
      Last update: 2016-07-26 14:21    [W:4.071 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site