lkml.org 
[lkml]   [2016]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.6 123/203] drm/i915/fbc: Disable on HSW by default for now
    Date
    4.6-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Lyude <cpaul@redhat.com>

    commit 1e3fa0acfec677e915d7de5ac6e1f18cfa4f805b upstream.

    >From https://bugs.freedesktop.org/show_bug.cgi?id=96461 :

    This was kind of a difficult bug to track down. If you're using a
    Haswell system running GNOME and you have fbc completely enabled and
    working, playing videos can result in video artifacts. Steps to
    reproduce:

    - Run GNOME
    - Ensure FBC is enabled and active
    - Download a movie, I used the ogg version of Big Buck Bunny for this
    - Run `gst-launch-1.0 filesrc location='some_movie.ogg' ! decodebin !
    glimagesink` in a terminal
    - Watch for about over a minute, you'll see small horizontal lines go
    down the screen.

    For the time being, disable FBC for Haswell by default.

    Stefan Richter reported kernel freezes (no video artifacts) when fbc
    is on. (E3-1245 v3 with HD P4600; openbox and some KDE and LXDE
    applications, thread begins at https://lkml.org/lkml/2016/4/26/813).
    We also got reports from Steven Honeyman on openbox+roxterm.

    v2 (From Paulo):
    - Add extra information to the commit message
    - Add Fixes tag
    - Rebase

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96461
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96464
    Fixes: a98ee79317b4 ("drm/i915/fbc: enable FBC by default on HSW and BDW")
    Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Signed-off-by: Lyude <cpaul@redhat.com>
    Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/1465487895-7401-1-git-send-email-cpaul@redhat.com
    (cherry picked from commit c7f7e2feffb0294302041507dfd5fc15f01afccc)
    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/i915/intel_fbc.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/gpu/drm/i915/intel_fbc.c
    +++ b/drivers/gpu/drm/i915/intel_fbc.c
    @@ -823,8 +823,7 @@ static bool intel_fbc_can_choose(struct
    {
    struct drm_i915_private *dev_priv = crtc->base.dev->dev_private;
    struct intel_fbc *fbc = &dev_priv->fbc;
    - bool enable_by_default = IS_HASWELL(dev_priv) ||
    - IS_BROADWELL(dev_priv);
    + bool enable_by_default = IS_BROADWELL(dev_priv);

    if (intel_vgpu_active(dev_priv->dev)) {
    fbc->no_fbc_reason = "VGPU is active";

    \
     
     \ /
      Last update: 2016-07-26 01:01    [W:4.081 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site