Messages in this thread | | | Date | Mon, 25 Jul 2016 16:35:44 -0400 | From | Johannes Weiner <> | Subject | Re: [PATCH -next] mm: Drop unnecessary include file |
| |
On Sat, Jul 23, 2016 at 10:50:08PM -0700, Guenter Roeck wrote: > Commmit e9be930fa6b5 ("mm: fix vm-scalability regression in cgroup-aware > workingset code") adds '#include <linux/mm.h>' to > include/linux/memcontrol.h. This results in the following build error > when building hexagon images. > > In file included from ./include/linux/memcontrol.h:32:0, > from ./include/linux/swap.h:8, > from ./arch/hexagon/include/asm/pgtable.h:27, > from mm/init-mm.c:9: > ./include/linux/mm.h:322:2: error: unknown type name 'pmd_t' > ./include/linux/mm.h:353:7: error: unknown type name 'pmd_t' > ./include/linux/mm.h:414:30: error: unknown type name 'pmd_t' > > The include file does not appear to be necessary, so just drop it. > > Fixes: e9be930fa6b5 ("mm: fix vm-scalability regression in cgroup-aware workingset code") > Cc: Johannes Weiner <hannes@cmpxchg.org> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
It was needed because mem_cgroup_zone_zoneinfo() used zone_to_nid(). Mel's nodelru patches have since renamed it to mem_cgroup_nodeinfo() and dropped the zone_to_nid() reference, that's why it's no longer necessary.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
[ I'd put it in after the nodelru patches, though, to maintain bisectability on x86 over hexagon. ]
| |