lkml.org 
[lkml]   [2016]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] mm/memblock.c: fix index adjustment error in __next_mem_range_rev()
On Mon, Jul 25, 2016 at 07:34:12AM +0000, zijun_hu@htc.com wrote:
> Hi All,
> There is a bug in mm/memblock.c
> Could you review and phase-in this patch?
> Thanks a lot
>
> From 3abf1822d30f77f126bd7a3c09bb243d9c17a029 Mon Sep 17 00:00:00 2001
> From: zijun_hu <zijun_hu@htc.com>
> Date: Mon, 25 Jul 2016 15:06:57 +0800
> Subject: [PATCH] mm/memblock.c: fix index adjustment error in
> __next_mem_range_rev()
>
> fix region index adjustment error when parameter type_b of
> __next_mem_range_rev() == NULL
>
> Signed-off-by: zijun_hu <zijun_hu@htc.com>
> ---
> mm/memblock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index ac12489..b14973e 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -1024,7 +1024,7 @@ void __init_memblock __next_mem_range_rev(u64 *idx, int nid, ulong flags,
> *out_end = m_end;
> if (out_nid)
> *out_nid = m_nid;
> - idx_a++;
> + idx_a--;

Looks good to me. Do you happen to have a test case for this bug?

Thanks.

--
tejun

\
 
 \ /
  Last update: 2016-07-25 21:41    [W:0.029 / U:21.464 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site