lkml.org 
[lkml]   [2016]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/4] usb: gadget: f_midi: fixed endianness when using wMaxPacketSize
    Hi,

    On 26 July 2016 at 07:15, Felipe F. Tonello <eu@felipetonello.com> wrote:
    > USB spec specifies wMaxPacketSize to be little endian (as other properties),
    > so when using this variable in the driver we should convert to the current
    > CPU endianness if necessary.
    >
    > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
    > ---
    > drivers/usb/gadget/function/f_midi.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
    > index 58fc199a18ec..a83d852b1da5 100644
    > --- a/drivers/usb/gadget/function/f_midi.c
    > +++ b/drivers/usb/gadget/function/f_midi.c
    > @@ -362,7 +362,7 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
    > struct usb_request *req =
    > midi_alloc_ep_req(midi->out_ep,
    > max_t(unsigned, midi->buflen,
    > - bulk_out_desc.wMaxPacketSize));
    > + le16_to_cpu(bulk_out_desc.wMaxPacketSize)));

    I think here we should use usb_ep_align_maybe() function instead of
    max_t() to handle 'quirk_ep_out_aligned_size' quirk, please see the
    patch I've send out: https://lkml.org/lkml/2016/7/12/106

    > if (req == NULL)
    > return -ENOMEM;
    >
    > --
    > 2.9.2
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html



    --
    Baolin.wang
    Best Regards

    \
     
     \ /
      Last update: 2016-07-26 04:21    [W:3.405 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site