lkml.org 
[lkml]   [2016]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] libnvdimm-btt: Delete an unnecessary check before the function call "__nd_device_register"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 24 Jul 2016 11:05:34 +0200

    The __nd_device_register() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/nvdimm/btt_devs.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/nvdimm/btt_devs.c b/drivers/nvdimm/btt_devs.c
    index 816d0da..3fa7919 100644
    --- a/drivers/nvdimm/btt_devs.c
    +++ b/drivers/nvdimm/btt_devs.c
    @@ -198,8 +198,7 @@ struct device *nd_btt_create(struct nd_region *nd_region)
    {
    struct device *dev = __nd_btt_create(nd_region, 0, NULL, NULL);

    - if (dev)
    - __nd_device_register(dev);
    + __nd_device_register(dev);
    return dev;
    }

    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-24 12:01    [W:6.026 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site