lkml.org 
[lkml]   [2016]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] firmware-gsmi: Delete an unnecessary check before the function call "dma_pool_destroy"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 24 Jul 2016 10:16:56 +0200

    The dma_pool_destroy() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/firmware/google/gsmi.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
    index f1ab05e..c463871 100644
    --- a/drivers/firmware/google/gsmi.c
    +++ b/drivers/firmware/google/gsmi.c
    @@ -910,8 +910,7 @@ out_err:
    gsmi_buf_free(gsmi_dev.param_buf);
    gsmi_buf_free(gsmi_dev.data_buf);
    gsmi_buf_free(gsmi_dev.name_buf);
    - if (gsmi_dev.dma_pool)
    - dma_pool_destroy(gsmi_dev.dma_pool);
    + dma_pool_destroy(gsmi_dev.dma_pool);
    platform_device_unregister(gsmi_dev.pdev);
    pr_info("gsmi: failed to load: %d\n", ret);
    return ret;
    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-24 11:01    [W:4.015 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site