lkml.org 
[lkml]   [2016]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] coresight: tmc: Delete an unnecessary check before the function call "kfree"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 23 Jul 2016 20:04:09 +0200

    The kfree() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/hwtracing/coresight/coresight-tmc-etf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c
    index e68289b..5fa49c4 100644
    --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c
    +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c
    @@ -168,7 +168,7 @@ out:
    spin_unlock_irqrestore(&drvdata->spinlock, flags);

    /* Free memory outside the spinlock if need be */
    - if (!used && buf)
    + if (!used)
    kfree(buf);

    if (!ret)
    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-23 20:41    [W:4.020 / U:0.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site