Messages in this thread | | | From | Andy Lutomirski <> | Date | Fri, 22 Jul 2016 11:10:16 -0700 | Subject | Re: [PATCH 2/3] x86: add some better documentation for probe_kernel_address() |
| |
On Jul 22, 2016 11:03 AM, "Dave Hansen" <dave@sr71.net> wrote: > > > From: Dave Hansen <dave.hansen@linux.intel.com> > > probe_kernel_address() has an unfortunate name since it is used > to probe kernel *and* userspace addresses. Add a comment > explaining some of the situation to help the next developer who > might make the silly assumption that it is for probing kernel > addresses.
This can't work on architectures like s390 that have separate, overlapping user and kernel address spaces. Maybe we should fix x86 to stop abusing it and use get_user instead. (In which case, your new function should be called get_user_insn_byte or similar.)
--Andy
| |