lkml.org 
[lkml]   [2016]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] zsmalloc: Delete an unnecessary check before the function call "iput"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 22 Jul 2016 19:54:20 +0200

    The iput() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    mm/zsmalloc.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
    index 5e5237c..7b5fd2b 100644
    --- a/mm/zsmalloc.c
    +++ b/mm/zsmalloc.c
    @@ -2181,8 +2181,7 @@ static int zs_register_migration(struct zs_pool *pool)
    static void zs_unregister_migration(struct zs_pool *pool)
    {
    flush_work(&pool->free_work);
    - if (pool->inode)
    - iput(pool->inode);
    + iput(pool->inode);
    }

    /*
    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-22 20:41    [W:4.539 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site