lkml.org 
[lkml]   [2016]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/4] GPU-DRM-Etnaviv: Delete unnecessary checks before two function calls
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 22 Jul 2016 15:56:15 +0200

    The functions drm_gem_object_unreference_unlocked() and vunmap() perform
    also input parameter validation.
    Thus the tests around their calls are not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/etnaviv/etnaviv_gem.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
    index 8c6f750..8eee742 100644
    --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
    +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
    @@ -535,8 +535,7 @@ void etnaviv_gem_describe_objects(struct etnaviv_drm_private *priv,

    static void etnaviv_gem_shmem_release(struct etnaviv_gem_object *etnaviv_obj)
    {
    - if (etnaviv_obj->vaddr)
    - vunmap(etnaviv_obj->vaddr);
    + vunmap(etnaviv_obj->vaddr);
    put_pages(etnaviv_obj);
    }

    @@ -670,9 +669,7 @@ static struct drm_gem_object *__etnaviv_gem_new(struct drm_device *dev,
    return obj;

    fail:
    - if (obj)
    - drm_gem_object_unreference_unlocked(obj);
    -
    + drm_gem_object_unreference_unlocked(obj);
    return ERR_PTR(ret);
    }

    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-22 18:21    [W:5.023 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site