lkml.org 
[lkml]   [2016]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 36/58] staging: lustre: lmv: fix issue found by Klocwork Insight tool
    Date
    From: Dmitry Eremin <dmitry.eremin@intel.com>

    'plock.cookie' might be used uninitialized in this function.

    sscanf format specification '%d' expects type 'int *' for 'd',
    but parameter 3 has a different type '__u32*'

    Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
    Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
    Reviewed-on: http://review.whamcloud.com/9390
    Reviewed-by: John L. Hammond <john.hammond@intel.com>
    Reviewed-by: James Simmons <uja.ornl@gmail.com>
    Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
    Signed-off-by: James Simmons <jsimmons@infradead.org>
    ---
    drivers/staging/lustre/lustre/lmv/lmv_intent.c | 6 ++++--
    drivers/staging/lustre/lustre/lmv/lmv_obd.c | 2 +-
    2 files changed, 5 insertions(+), 3 deletions(-)

    diff --git a/drivers/staging/lustre/lustre/lmv/lmv_intent.c b/drivers/staging/lustre/lustre/lmv/lmv_intent.c
    index 2bc1098..51b7048 100644
    --- a/drivers/staging/lustre/lustre/lmv/lmv_intent.c
    +++ b/drivers/staging/lustre/lustre/lmv/lmv_intent.c
    @@ -137,8 +137,10 @@ static int lmv_intent_remote(struct obd_export *exp, void *lmm,
    it->it_remote_lock_mode = it->it_lock_mode;
    }

    - it->it_lock_handle = plock.cookie;
    - it->it_lock_mode = pmode;
    + if (pmode) {
    + it->it_lock_handle = plock.cookie;
    + it->it_lock_mode = pmode;
    + }

    out_free_op_data:
    kfree(op_data);
    diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
    index e51ea1f..9e3d35a 100644
    --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
    +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
    @@ -1421,7 +1421,7 @@ static int lmv_process_config(struct obd_device *obd, u32 len, void *buf)

    obd_str2uuid(&obd_uuid, lustre_cfg_buf(lcfg, 1));

    - if (sscanf(lustre_cfg_buf(lcfg, 2), "%d", &index) != 1) {
    + if (sscanf(lustre_cfg_buf(lcfg, 2), "%u", &index) != 1) {
    rc = -EINVAL;
    goto out;
    }
    --
    1.7.1
    \
     
     \ /
      Last update: 2016-07-22 06:21    [W:2.321 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site