lkml.org 
[lkml]   [2016]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] pstore/ram: Set pstore flags dynamically
Hi,

[auto build test WARNING on ia64/next]
[also build test WARNING on v4.7-rc7]
[cannot apply to next-20160721]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Namhyung-Kim/pstore-Split-pstore-fragile-flags/20160722-060839
base: https://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git next
config: i386-randconfig-x0-07220732 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

In file included from include/linux/linkage.h:4:0,
from include/linux/kernel.h:6,
from fs/pstore/ram.c:25:
fs/pstore/ram.c: In function 'ramoops_probe':
fs/pstore/ram.c:543:6: error: 'ctx' undeclared (first use in this function)
if (ctx->console_size)
^
include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> fs/pstore/ram.c:543:2: note: in expansion of macro 'if'
if (ctx->console_size)
^~
fs/pstore/ram.c:543:6: note: each undeclared identifier is reported only once for each function it appears in
if (ctx->console_size)
^
include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> fs/pstore/ram.c:543:2: note: in expansion of macro 'if'
if (ctx->console_size)
^~
fs/pstore/ram.c:544:24: error: 'PSTORE_FLAGS_CONOLE' undeclared (first use in this function)
cxt->pstore.flags |= PSTORE_FLAGS_CONOLE;
^~~~~~~~~~~~~~~~~~~

vim +/if +543 fs/pstore/ram.c

527 * have to handle dumps, we must have at least record_size buffer. And
528 * for ftrace, bufsize is irrelevant (if bufsize is 0, buf will be
529 * ZERO_SIZE_PTR).
530 */
531 if (cxt->console_size)
532 cxt->pstore.bufsize = 1024; /* LOG_LINE_MAX */
533 cxt->pstore.bufsize = max(cxt->record_size, cxt->pstore.bufsize);
534 cxt->pstore.buf = kmalloc(cxt->pstore.bufsize, GFP_KERNEL);
535 spin_lock_init(&cxt->pstore.buf_lock);
536 if (!cxt->pstore.buf) {
537 pr_err("cannot allocate pstore buffer\n");
538 err = -ENOMEM;
539 goto fail_clear;
540 }
541
542 cxt->pstore.flags = PSTORE_FLAGS_DMESG;
> 543 if (ctx->console_size)
544 cxt->pstore.flags |= PSTORE_FLAGS_CONOLE;
545 if (ctx->ftrace_size)
546 cxt->pstore.flags |= PSTORE_FLAGS_FTRACE;
547 if (ctx->pmsg_size)
548 cxt->pstore.flags |= PSTORE_FLAGS_PMSG;
549
550 err = pstore_register(&cxt->pstore);
551 if (err) {

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2016-07-22 03:01    [W:0.065 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site