Messages in this thread | | | Date | Thu, 21 Jul 2016 13:27:56 +0100 | From | Andy Whitcroft <> | Subject | Re: [PATCH] checkpatch: Yet another commit id improvement |
| |
On Tue, Jul 19, 2016 at 03:05:56AM -0700, Joe Perches wrote: > On Tue, 2016-07-19 at 10:51 +0100, Andy Whitcroft wrote: > > On Mon, Jul 18, 2016 at 12:27:42PM -0700, Joe Perches wrote: > > > > > > Using \b isn't good enough to isolate what appears to be a > > > commit id in a commit message. > > > > > > Make sure there is a space or a quote like character after > > > a continuous run of hexadecimal characters that could be > > > a commit id. > [] > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] > > > @@ -2460,9 +2460,9 @@ sub process { > > > > > > # Check for git id commit length and improperly formed commit descriptions > > > if ($in_commit_log && !$commit_log_possible_stack_dump && > > > - $line !~ /^\s*(?:Link|Patchwork|http|BugLink):/i && > > > + $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i && > > > ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i || > > > - ($line =~ /\b[0-9a-f]{12,40}\b/i && > > > + ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i && > > If we expect a quote after would it be unreasonable to allow then at the > > beginning too? > > Perhaps not. The idea is the quote starts the commit description > not ends the commit SHA-1 hash.
Then carry on as before. Looks fine.
-apw
| |