Messages in this thread | | | From | Kalle Valo <> | Subject | Re: linux-next: build warning after merge of the wireless-drivers-next tree | Date | Wed, 20 Jul 2016 21:41:49 +0300 |
| |
"Reizer, Eyal" <eyalr@ti.com> writes:
>> After merging the wireless-drivers-next tree, today's linux-next build >> (x86_64 allmodconfig) produced this warning: >> >> drivers/net/wireless/ti/wlcore/spi.c: In function 'wlcore_probe_of': >> drivers/net/wireless/ti/wlcore/spi.c:457:6: warning: unused variable 'ret' [- >> Wunused-variable] >> int ret; >> ^ >> >> Introduced by commit >> >> 01efe65aba65 ("wlcore: spi: add wl18xx support") > > Of course you are right. It is indeed redundant now. Don't know how I >have missed it. Don't remember seeing a warning from the tool chain I >have used. Anyway ,will submit an amended patch soon.
I didn't notice it either as I didn't have CONFIG_WLCORE_SPI enabled. But what's odd is that kbuild didn't report anything, it's usually quite good to catch warnings like this.
Anyway, I have pushed the fix to wireless-drivers-next:
cb6a11518850 wlcore: spi: fix build warning caused by redundant variable
-- Kalle Valo
| |