Messages in this thread | | | Date | Wed, 20 Jul 2016 08:45:25 -0400 | From | William Breathitt Gray <> | Subject | Re: [PATCH 0/6] radio: Utilize the module_isa_driver macro |
| |
On Wed, Jul 20, 2016 at 12:37:31PM +0200, Hans Verkuil wrote: >On 07/18/2016 04:45 PM, William Breathitt Gray wrote: >> The module_isa_driver macro is a helper macro for ISA drivers which do >> not do anything special in module init/exit. This patchset eliminates a >> lot of ISA driver registration boilerplate code by utilizing >> module_isa_driver, which replaces module_init and module_exit. >> >> William Breathitt Gray (6): >> radio: terratec: Utilize the module_isa_driver macro >> radio: rtrack2: Utilize the module_isa_driver macro >> radio: trust: Utilize the module_isa_driver macro >> radio: zoltrix: Utilize the module_isa_driver macro >> radio: aztech: Utilize the module_isa_driver macro >> radio: aimslab: Utilize the module_isa_driver macro > >Good idea, but it doesn't compile: > >module_isa_driver(terratec_driver.driver, 1); > >expands to: > >static int __init terratec_driver.driver_init(void) >{ > return isa_register_driver(&(terratec_driver.driver), 1); >} > >So now the function name contains a '.' and it won't compile. > >Regards, > > Hans
Oops, looks like I was a bit on autopilot there. I'll have to rethink this patchset at a later point to overcome the symbol naming issue.
Thank you,
William Breathitt Gray
| |