Messages in this thread | | | Date | Sat, 2 Jul 2016 06:37:47 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH] spi: spi-bfin5xx: Remove deprecated create_singlethread_workqueue |
| |
On Sat, Jul 02, 2016 at 02:12:00PM +0530, Bhaktipriya Shridhar wrote: > The workqueue "workqueue" serves as a driver message queue. > It has a single work item(&drv_data->pump_messages) and hence doesn't > require ordering. Also, it is not being used on a memory reclaim path. > Hence, the singlethreaded workqueue has been replaced with the use of > system_wq. > > System workqueues have been able to handle high level of concurrency > for a long time now and hence it's not required to have a singlethreaded > workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue > created with create_singlethread_workqueue(), system_wq allows multiple > work items to overlap executions even on the same CPU; however, a > per-cpu workqueue doesn't have any CPU locality or global ordering > guarantee unless the target CPU is explicitly specified and thus the > increase of local concurrency shouldn't make any difference. > > Work item has been flushed in bfin_spi_destroy_queue() to ensure that there > are no pending tasks while disconnecting the driver. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |