lkml.org 
[lkml]   [2016]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/2] Input-at32psif: Return directly after a failed kzalloc() in psif_probe()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 2 Jul 2016 18:34:43 +0200

    Return directly after a memory allocation failed at the beginning.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/input/serio/at32psif.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/input/serio/at32psif.c b/drivers/input/serio/at32psif.c
    index 2e4ff5b..fcb769a 100644
    --- a/drivers/input/serio/at32psif.c
    +++ b/drivers/input/serio/at32psif.c
    @@ -212,8 +212,7 @@ static int __init psif_probe(struct platform_device *pdev)
    psif = kzalloc(sizeof(struct psif), GFP_KERNEL);
    if (!psif) {
    dev_dbg(&pdev->dev, "out of memory\n");
    - ret = -ENOMEM;
    - goto out;
    + return -ENOMEM;
    }
    psif->pdev = pdev;

    @@ -297,7 +296,6 @@ out_free_io:
    kfree(io);
    out_free_psif:
    kfree(psif);
    -out:
    return ret;
    }

    --
    2.9.0
    \
     
     \ /
      Last update: 2016-07-02 21:41    [W:4.026 / U:0.700 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site