lkml.org 
[lkml]   [2016]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC][PATCH 03/10 v2] k3dma: Fix "nobody cared" message seen on any error
    Date
    From: Andy Green <andy.green@linaro.org>

    As it was before, as soon as the DMAC IP felt there was an error
    he would return IRQ_NONE since no actual transfer had completed.

    After spinning on that for 100K interrupts, Linux yanks the IRQ with
    a "nobody cared" error.

    This patch lets it handle the interrupt and keep the IRQ alive.

    Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
    Cc: Jingoo Han <jg1.han@samsung.com>
    Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
    Cc: Vinod Koul <vinod.koul@intel.com>
    Cc: Dan Williams <dan.j.williams@intel.com>
    Cc: Liam Girdwood <lgirdwood@gmail.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Jaroslav Kysela <perex@perex.cz>
    Cc: Takashi Iwai <tiwai@suse.com>
    Cc: Wei Xu <xuwei5@hisilicon.com>
    Cc: Rob Herring <robh+dt@kernel.org>
    Cc: Andy Green <andy@warmcat.com>
    Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
    Signed-off-by: Andy Green <andy.green@linaro.org>
    [jstultz: Forward ported to mainline]
    Signed-off-by: John Stultz <john.stultz@linaro.org>
    ---
    drivers/dma/k3dma.c | 8 +++++---
    1 file changed, 5 insertions(+), 3 deletions(-)

    diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
    index 8dd050c..c2906a82 100644
    --- a/drivers/dma/k3dma.c
    +++ b/drivers/dma/k3dma.c
    @@ -220,11 +220,13 @@ static irqreturn_t k3_dma_int_handler(int irq, void *dev_id)
    writel_relaxed(err1, d->base + INT_ERR1_RAW);
    writel_relaxed(err2, d->base + INT_ERR2_RAW);

    - if (irq_chan) {
    + if (irq_chan)
    tasklet_schedule(&d->task);
    +
    + if (irq_chan || err1 || err2)
    return IRQ_HANDLED;
    - } else
    - return IRQ_NONE;
    +
    + return IRQ_NONE;
    }

    static int k3_dma_start_txd(struct k3_dma_chan *c)
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-07-20 02:01    [W:3.036 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site