Messages in this thread Patch in this message | | | Subject | [PATCH] [media] v4l2-common: Delete an unnecessary check before the function call "spi_unregister_device" | From | SF Markus Elfring <> | Date | Tue, 19 Jul 2016 20:02:10 +0200 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 19 Jul 2016 19:54:16 +0200
The spi_unregister_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/media/v4l2-core/v4l2-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c index 5b80850..57cfe26a 100644 --- a/drivers/media/v4l2-core/v4l2-common.c +++ b/drivers/media/v4l2-core/v4l2-common.c @@ -291,7 +291,7 @@ struct v4l2_subdev *v4l2_spi_new_subdev(struct v4l2_device *v4l2_dev, error: /* If we have a client but no subdev, then something went wrong and we must unregister the client. */ - if (spi && sd == NULL) + if (!sd) spi_unregister_device(spi); return sd; -- 2.9.2
| |