Messages in this thread | | | Subject | Re: [PATCH V3 01/10] Documentation: dt-bindings: mailbox: tegra: Add binding for HSP mailbox | From | Stephen Warren <> | Date | Tue, 19 Jul 2016 10:36:27 -0600 |
| |
On 07/19/2016 03:17 AM, Joseph Lo wrote: > Add DT binding for the Hardware Synchronization Primitives (HSP). The > HSP is designed for the processors to share resources and communicate > together. It provides a set of hardware synchronization primitives for > interprocessor communication. So the interprocessor communication (IPC) > protocols can use hardware synchronization primitive, when operating > between two processors not in an SMP relationship.
Acked-by: Stephen Warren <swarren@nvidia.com>
A couple of nits below that you might want to fix up when posting the final version of the series; your call.
> diff --git a/include/dt-bindings/mailbox/tegra186-hsp.h b/include/dt-bindings/mailbox/tegra186-hsp.h
> + */ > + > + > +#ifndef _DT_BINDINGS_MAILBOX_TEGRA186_HSP_H
Nit: There are 2 blank lines there.
> +#endif /* _DT_BINDINGS_MAILBOX_TEGRA186_HSP_H */
Nit: Personally I hate "filename" comments on the #endif, since it's just one more place to update if the file moves or is copied.
| |