lkml.org 
[lkml]   [2016]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()
On 05/07/2016 at 15:28:53 +0530, Alim Akhtar wrote :
> As per code flow s3c_rtc_setfreq() will get called with rtc clock disabled
> and in set_freq we perform h/w registers read/write, which results in a
> kernel crash on exynos7 platform while probing rtc driver.
> Below is code flow:
> s3c_rtc_probe()
> clk_prepare_enable(info->rtc_clk) // rtc clock enabled
> s3c_rtc_gettime() // will enable clk if not done, and disable it upon exit
> s3c_rtc_setfreq() //then this will be called with clk disabled
>
> This patch take cares of such issue by adding s3c_rtc_{enable/disable}_clk in
> s3c_rtc_setfreq().
>
> Fixes: 24e1455493da ("drivers/rtc/rtc-s3c.c: delete duplicate clock control")
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> drivers/rtc/rtc-s3c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

\
 
 \ /
  Last update: 2016-07-19 18:41    [W:0.077 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site