Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] mtd: add arch dependency for MTD_BCM47XXSFLASH symbol | Date | Tue, 19 Jul 2016 17:10:10 +0300 |
| |
Brian Norris <computersforpeace@gmail.com> writes:
> On Tue, Jul 19, 2016 at 09:08:32AM +0200, Rafał Miłecki wrote: >> We dropped strict MIPS dependency for bcm47xxsflash driver in: >> commit 5651d6aaf489 ("mtd: bcm47xxsflash: use ioremap_cache() instead of >> KSEG0ADDR()") but using ioremap_cache still limits building it to few >> selected architectures only. >> >> A recent commit 57d8f7dd2132 ("bcma: allow enabling serial flash support >> on non-MIPS SoCs") automatically dropped MIPS dependency for >> MTD_BCM47XXSFLASH which broke building e.g. on powerpc and cris. >> >> The bcma change is alright as it doesn't break building bcma code in any >> way. MTD_BCM47XXSFLASH on the other hand should be limited to archs >> which need it and can build it (by providing ioremap_cache). >> >> Fixes: 57d8f7dd2132 ("bcma: allow enabling serial flash support on non-MIPS SoCs") >> Signed-off-by: Rafał Miłecki <zajec5@gmail.com> >> Cc: Brian Norris <computersforpeace@gmail.com> > > While I might prefer we have a better consistent set of portable I/O > accessors (it's really a mess), it seems quite reasonable to restrict > the damage to ARM and MIPS here if it saves some short-term hassle: > > Acked-by: Brian Norris <computersforpeace@gmail.com> > >> --- >> That bcma commit breaking building landed in the wireless-drivers-next. >> Is that possible to get this patch through the same tree? > > That's fine with me.
Great, thanks. I'm planning to apply this later tonight to fix the build error.
-- Kalle Valo
| |