Messages in this thread Patch in this message | | | Subject | [PATCH] [media] cec: Delete an unnecessary check before the function call "rc_free_device" | From | SF Markus Elfring <> | Date | Sun, 17 Jul 2016 23:00:15 +0200 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 17 Jul 2016 22:52:49 +0200
The rc_free_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/staging/media/cec/cec-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/cec/cec-core.c b/drivers/staging/media/cec/cec-core.c index 61a1e69..123e1bf 100644 --- a/drivers/staging/media/cec/cec-core.c +++ b/drivers/staging/media/cec/cec-core.c @@ -354,8 +354,7 @@ void cec_delete_adapter(struct cec_adapter *adap) if (adap->kthread_config) kthread_stop(adap->kthread_config); #if IS_ENABLED(CONFIG_RC_CORE) - if (adap->rc) - rc_free_device(adap->rc); + rc_free_device(adap->rc); #endif kfree(adap); } -- 2.9.1
| |