lkml.org 
[lkml]   [2016]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] dts: hi6220: Add k3-dma and i2s/hdmi audio support
On Fri, Jul 15, 2016 at 07:13:27PM -0700, John Stultz wrote:

> Add entry for k3-dma driver and i2s/hdmi audio devices.

> This enables HDMI audio output.

These bindings appear to be undocumented. All new bindings require
documentation.

> + i2s0: hi6210_i2s {
> + compatible = "hisilicon,hi6210-i2s";
> + reg = <0x0 0xf7118000 0x0 0x8000>, /* i2s unit */
> + <0x0 0xf7030000 0x0 0x400>, /* syscon */
> + <0x0 0xf7032000 0x0 0x400>; /* pmctrl */

Some of this looks like we should be using a system controller binding
rather than listing the system controller directly here. The magic
number indexing for the resources is also not good, we should be using
reg-names to get name based lookups (I had been going to query that on
the binding document when I failed to find it...).
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-07-16 14:21    [W:0.129 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site