lkml.org 
[lkml]   [2016]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/8] drm/amdgpu/powerplay: Delete unnecessary checks before the function call "kfree"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 16 Jul 2016 12:38:12 +0200

    The kfree() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the calls is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 3 +--
    drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c | 5 +----
    2 files changed, 2 insertions(+), 6 deletions(-)

    diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
    index cf6f49f..6f11bc1 100644
    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
    @@ -1053,8 +1053,7 @@ static int amdgpu_cgs_acpi_eval_object(struct cgs_device *cgs_device,
    }

    error:
    - if (obj != NULL)
    - kfree(obj);
    + kfree(obj);
    kfree((void *)input.pointer);
    return result;
    }
    diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
    index 7a705ce..024e22e 100644
    --- a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
    +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
    @@ -76,10 +76,7 @@ int phm_dispatch_table(struct pp_hwmgr *hwmgr,
    }

    result = phm_run_table(hwmgr, rt_table, input, output, temp_storage);
    -
    - if (NULL != temp_storage)
    - kfree(temp_storage);
    -
    + kfree(temp_storage);
    return result;
    }

    --
    2.9.1
    \
     
     \ /
      Last update: 2016-07-16 17:21    [W:2.420 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site