lkml.org 
[lkml]   [2016]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] testing/radix-tree: fix a macro expansion bug
On Sat, Jul 16, 2016 at 12:09:53AM +0300, Dan Carpenter wrote:
> There are no parentheses around this macro and it causes a problem when
> we do:
>
> index = rand() % THRASH_SIZE;
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Ross Zwisler <ross.zwisler@linux.intel.com>

>
> diff --git a/tools/testing/radix-tree/tag_check.c b/tools/testing/radix-tree/tag_check.c
> index b7447ce..b0ac057 100644
> --- a/tools/testing/radix-tree/tag_check.c
> +++ b/tools/testing/radix-tree/tag_check.c
> @@ -122,7 +122,7 @@ enum {
> NODE_TAGGED = 2,
> };
>
> -#define THRASH_SIZE 1000 * 1000
> +#define THRASH_SIZE (1000 * 1000)
> #define N 127
> #define BATCH 33
>

\
 
 \ /
  Last update: 2016-07-16 00:21    [W:0.041 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site