lkml.org 
[lkml]   [2016]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] drm/vc4: Delete unnecessary checks before two function calls
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 15 Jul 2016 21:15:37 +0200

    The following functions test whether their argument is NULL
    and then return immediately.
    * drm_fbdev_cma_hotplug_event
    * drm_fbdev_cma_restore_mode

    Thus the tests around their calls are not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/vc4/vc4_drv.c | 3 +--
    drivers/gpu/drm/vc4/vc4_kms.c | 3 +--
    2 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
    index 54d0471..ce74d86 100644
    --- a/drivers/gpu/drm/vc4/vc4_drv.c
    +++ b/drivers/gpu/drm/vc4/vc4_drv.c
    @@ -47,8 +47,7 @@ static void vc4_lastclose(struct drm_device *dev)
    {
    struct vc4_dev *vc4 = to_vc4_dev(dev);

    - if (vc4->fbdev)
    - drm_fbdev_cma_restore_mode(vc4->fbdev);
    + drm_fbdev_cma_restore_mode(vc4->fbdev);
    }

    static const struct file_operations vc4_drm_fops = {
    diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c
    index 9a217fd..4ac894d 100644
    --- a/drivers/gpu/drm/vc4/vc4_kms.c
    +++ b/drivers/gpu/drm/vc4/vc4_kms.c
    @@ -26,8 +26,7 @@ static void vc4_output_poll_changed(struct drm_device *dev)
    {
    struct vc4_dev *vc4 = to_vc4_dev(dev);

    - if (vc4->fbdev)
    - drm_fbdev_cma_hotplug_event(vc4->fbdev);
    + drm_fbdev_cma_hotplug_event(vc4->fbdev);
    }

    struct vc4_commit {
    --
    2.9.1
    \
     
     \ /
      Last update: 2016-07-15 22:01    [W:4.188 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site