lkml.org 
[lkml]   [2016]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] tpm: add driver for cr50 on SPI
On Thu, Jul 14, 2016 at 09:28:14PM -0600, Jason Gunthorpe wrote:
> On Thu, Jul 14, 2016 at 07:50:26PM -0700, Andrey Pronin wrote:
> > Yes, it has a TCG-compliant interface, however, there are several things
> > specific to this device:
> > - need to ensure a certain delay between spi transactions, or else
> > the chip can miss several first bytes.
> > - if there is no spi activity for this chip, it may go to sleep, and
> > needs to be waken up before sending further commands.
> > - it has some vendor-specific registers accessible from spi bus.
>
> This all needs to be commented clearly in the driver..
>

Will provide more details in the patch description. The driver code
has comments about those cases in the code: see cr50_ensure_access_delay
and cr50_needs_waking, for example.

\
 
 \ /
  Last update: 2016-07-15 19:41    [W:0.059 / U:53.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site