Messages in this thread |  | | From | "Rosen, Rami" <> | Subject | RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware) | Date | Thu, 14 Jul 2016 18:59:54 +0000 |
| |
Hi, Amir,
>This patch is the communication with the FW. >The network functionality is added in the next patches in the series >and with it, more messages from FW. >Indeed this function always returns true in this patch, >but while writing it, I predicted that the network functionality will >use the send_event flag differently. >You can see the documentation of send_event - currently unused in this patch. >I don't see any harm that in this patch, this function will always return true, >while applying the rest of the series will change it.
Ok, seems reasonable.
>The prototype of suspend is return int: >http://lxr.free-electrons.com/source/include/linux/pm.h#L295
>The prototype of resume is return int: >http://lxr.free-electrons.com/source/include/linux/pm.h#L295
You are right about this, I missed the macro invocation in your code, SET_SYSTEM_SLEEP_PM_OPS(nhi_suspend, nhi_resume), apologies.
Regards, Rami Rosen Intel Corporation
|  |