lkml.org 
[lkml]   [2016]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v9 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver
Hi Joe,

On Thu, Jul 14, 2016 at 10:47 AM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2016-07-14 at 10:27 -0700, Tai Nguyen wrote:
>> This patch adds a driver for the SoC-wide (AKA uncore) PMU hardware
>> found in APM X-Gene SoCs.
>
> trivia:
>
>> diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
> []
>> +struct xgene_pmu_dev_ctx {
>> + char *name;
>> + struct list_head next;
>> + struct xgene_pmu_dev *pmu_dev;
>> + struct hw_pmu_info inf;
>> +};
>
> Probably better to use something like
> char name[20];
> as the kasprintf can fail and this doesn't
> seem to be freed anywhere.

Okay. I'll fix it shortly.

[...]

Thanks,
--
Tai

\
 
 \ /
  Last update: 2016-07-14 20:41    [W:0.053 / U:2.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site