lkml.org 
[lkml]   [2016]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable
Hi list,

I just wondered: I send the patch >14 days ago, 9 days ago it was
reviewed by Rex Zhu. As far as I know, it isn't applied by now. At
least I did not get a mail indicating that it was applied.

Are there issues with the patch I missed?

On 05-07-2016 15:06:59, Zhu, Rex wrote:
>
> Yes, stretch_amount2 was not used on Polaris.
>
>
> Patch was Reviewed-by: Rex Zhu <Rex.Zhu@amd.com>
>
>
> Thanks.
>
>
> Best Regards
>
> Rex
>
> ________________________________
> From: Matthias Beyer <mail@beyermatthias.de>
> Sent: Friday, July 1, 2016 12:38:49 AM
> To: linuxdev.baldrick@gmail.com
> Cc: Deucher, Alexander; Koenig, Christian; airlied@linux.ie; dri-devel@lists.freedesktop.org; dcb314@hotmail.com; linux-kernel@vger.kernel.org; Zhu, Rex; Huang, JinHuiEric; nils.wallmenius@gmail.com; Matthias Beyer
> Subject: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable
>
> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
> index 64ee78f..1dcd52d 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
> @@ -1761,7 +1761,7 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
> {
> uint32_t ro, efuse, volt_without_cks, volt_with_cks, value, max, min;
> struct polaris10_hwmgr *data = (struct polaris10_hwmgr *)(hwmgr->backend);
> - uint8_t i, stretch_amount, stretch_amount2, volt_offset = 0;
> + uint8_t i, stretch_amount, volt_offset = 0;
> struct phm_ppt_v1_information *table_info =
> (struct phm_ppt_v1_information *)(hwmgr->pptable);
> struct phm_ppt_v1_clock_voltage_dependency_table *sclk_table =
> @@ -1806,11 +1806,8 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
> }
>
> /* Populate CKS Lookup Table */
> - if (stretch_amount == 1 || stretch_amount == 2 || stretch_amount == 5)
> - stretch_amount2 = 0;
> - else if (stretch_amount == 3 || stretch_amount == 4)
> - stretch_amount2 = 1;
> - else {
> + if (stretch_amount != 1 && stretch_amount != 2 && stretch_amount != 3 &&
> + stretch_amount != 4 && stretch_amount != 5) {
> phm_cap_unset(hwmgr->platform_descriptor.platformCaps,
> PHM_PlatformCaps_ClockStretcher);
> PP_ASSERT_WITH_CODE(false,
> --
> 2.9.0
>

--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer

Proudly sent with mutt.
Happily signed with gnupg.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-07-14 20:01    [W:0.055 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site