lkml.org 
[lkml]   [2016]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch net-next 2/2] devlink: fix trace format string
    From
    Date
    On 07/14/16 02:37, Jiri Pirko wrote:
    > From: Arnd Bergmann <arnd@arndb.de>
    >
    > Including devlink.h on ARM and probably other 32-bit architectures results in
    > a harmless warning:
    >
    > In file included from ../include/trace/define_trace.h:95:0,
    > from ../include/trace/events/devlink.h:51,
    > from ../net/core/devlink.c:30:
    > include/trace/events/devlink.h: In function 'trace_raw_output_devlink_hwmsg':
    > include/trace/events/devlink.h:42:12: error: format '%lu' expects argument of type 'long unsigned int', but argument 10 has type 'size_t {aka unsigned int}' [-Werror=format=]
    >
    > The correct format string for 'size_t' is %zu, not %lu, this works on all
    > architectures.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > Fixes: e5224f0fe2ac ("devlink: add hardware messages tracing facility")
    > Signed-off-by: Jiri Pirko <jiri@mellanox.com>

    Acked-by: Randy Dunlap <rdunlap@infradead.org>

    Thanks.

    > ---
    > include/trace/events/devlink.h | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h
    > index 77dce71..09f1df2 100644
    > --- a/include/trace/events/devlink.h
    > +++ b/include/trace/events/devlink.h
    > @@ -39,7 +39,7 @@ TRACE_EVENT(devlink_hwmsg,
    > __entry->len = len;
    > ),
    >
    > - TP_printk("bus_name=%s dev_name=%s driver_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%lu",
    > + TP_printk("bus_name=%s dev_name=%s driver_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%zu",
    > __get_str(bus_name), __get_str(dev_name),
    > __get_str(driver_name), __entry->incoming, __entry->type,
    > (int) __entry->len, __get_dynamic_array(buf), __entry->len)
    >


    --
    ~Randy

    \
     
     \ /
      Last update: 2016-07-14 19:41    [W:3.754 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site