lkml.org 
[lkml]   [2016]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 3/4] KVM: x86: add support for emulating UMIP
From
Date


On 13/07/2016 22:03, Radim Krčmář wrote:
> 2016-07-12 21:20+0200, Paolo Bonzini:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
>> @@ -3738,6 +3747,10 @@ static int em_lidt(struct x86_emulate_ctxt *ctxt)
>>
>> static int em_smsw(struct x86_emulate_ctxt *ctxt)
>> {
>> + if ((ctxt->ops->get_cr(ctxt, 4) & X86_CR4_UMIP) &&
>> + ctxt->ops->cpl(ctxt) > 0)
>
> UMIP should #GP(0) in virtual-8086 mode too (for SMSW, SIDT, and SGDT),
> but cpl() returns 0 in vm86.

No, it returns 3.

vmx->rmode.vm86_active means "there is no unrestricted guest support,
and we're using VM86 mode to emulate real mode". The special case in
vmx_get_cpl is needed exactly because real mode CPL is 0 but VM86 has
CPL 3. In fact fix_rmode_seg sets DPL=3 for all segments, and CPL=SS.DPL.

Paolo

>> + return emulate_gp(ctxt, 0);
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

\
 
 \ /
  Last update: 2016-07-14 09:41    [W:0.051 / U:2.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site