Messages in this thread | | | Date | Thu, 14 Jul 2016 09:05:39 -0700 | From | Brian Norris <> | Subject | Re: [PATCH -next] mtd: nand: omap2: fix return value check in omap_nand_probe() |
| |
On Thu, Jul 14, 2016 at 12:06:45PM +0000, weiyj_lk@163.com wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > In case of error, the function dma_request_chan() returns ERR_PTR() and > never returns NULL. The NULL test in the return value check should be > replaced with IS_ERR(). > > Fixes: aa7abd312c11 ('mtd: nand: omap2: Support parsing dma channel > information from DT') > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Brian Norris <computersforpeace@gmail.com>
Boris,
The affected commit is in your pull request, which I might review/pull today. I'll just plan on applying this on top, unless you'd prefer to fixup and resend.
Brian
| |