Messages in this thread | | | Date | Thu, 14 Jul 2016 08:58:49 -0700 | From | Brian Norris <> | Subject | Re: [PATCH] mtd: nand: omap2: add missing braces |
| |
On Thu, Jul 14, 2016 at 11:53:48AM +0200, Arnd Bergmann wrote: > A bug fix just introduced incorrect behavior in the omap2 nand driver, as > found by gcc-6.1: > > drivers/mtd/nand/omap2.c: In function 'omap_get_dt_info': > drivers/mtd/nand/omap2.c:1658:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation] > if (!info->elm_of_node) > ^~ > drivers/mtd/nand/omap2.c:1660:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' > if (!info->elm_of_node) > ^~ > > We clearly need to put the indented code into { } braces to get the intended > behavior. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 3bbca2c54f86 ("mtd: nand: omap2: Add check for old elm binding")
Wow, can't believe I missed that. Squashed into the original patch.
Thanks, Brian
| |