lkml.org 
[lkml]   [2016]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/8] x86: audit and remove needless module.h includes
[Re: [PATCH 0/8] x86: audit and remove needless module.h includes] On 14/07/2016 (Thu 15:04) Ingo Molnar wrote:

>
> * Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>
> > To that end, I have done allmodconfig, allyesconfig and allnoconfig
> > for both 32 bit and 64 bit x86 with these changes on the linux-next
> > from today, which presumably has an up to date copy of tip in it.
>
> It does, still I get this on allnoconfig with your patches applied:

Took me a while to figure out why I didn't see this; I was able to
finally reproduce it on x86-32 with allnoconfig but CONFIG_SMP=y.

>
> arch/x86/kernel/setup_percpu.c: In function ‘setup_percpu_segment’:
> arch/x86/kernel/setup_percpu.c:159:2: error: implicit declaration of function
> ‘pack_descriptor’ [-Werror=implicit-function-declaration]
> pack_descriptor(&gdt, per_cpu_offset(cpu), 0xFFFFF,
> ^
> arch/x86/kernel/setup_percpu.c:162:2: error: implicit declaration of function
> ‘write_gdt_entry’ [-Werror=implicit-function-declaration]
> write_gdt_entry(get_cpu_gdt_table(cpu),
> ^
> arch/x86/kernel/setup_percpu.c:162:18: error: implicit declaration of function
> ‘get_cpu_gdt_table’ [-Werror=implicit-function-declaration]
> write_gdt_entry(get_cpu_gdt_table(cpu),

All three of these guys live in asm/desc.h and adding that to the top of
arch/x86/kernel/setup_percpu.c asm include list seems to fix the
reproducer I now have here.

>
> I'll continue testing with the setup_percpu.c change left out.

Let me know if you want a resend or if you want to just add the
asm/desc.h locally or ...

Paul.
--

>
> Thanks,
>
> Ingo

\
 
 \ /
  Last update: 2016-07-14 18:01    [W:0.096 / U:18.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site