lkml.org 
[lkml]   [2016]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR
Date


On 7/13/16, 9:28 PM, "Martin K. Petersen" <martin.petersen@oracle.com> wrote:

>>>>>> "Johannes" == Johannes Thumshirn <jthumshirn@suse.de> writes:
>
>Johannes> qla2xxx first calls request_irq() and then does the setup of
>Johannes> the queue entry data needed in the interrupt handlers in when
>Johannes> using MSI-X. This could lead to a NULL pointer dereference
>Johannes> when an IRQ fires between the request_irq() call and the
>Johannes> assignment of the qentry data structure to the
>rsp-> msix field. A possible case for such a race would be in the kdump
>Johannes> case when the HBA's IRQs are still enabled but the driver is
>Johannes> undergoing a new initialisation and thus is not aware of
>Johannes> already activated IRQs in the HBA.
>
>Qlogic folks: Please review!

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@qlogic.com>


>
>--
>Martin K. Petersen Oracle Linux Engineering
\
 
 \ /
  Last update: 2016-07-14 17:01    [W:0.056 / U:7.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site